-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
branch: feature 1218 docker image
- makes Metacat deployable on Kubernetes, using a Helm Chart
#1637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The password file is now updated with the Metacat password admin utility.
Note that for now this only changes the context on the core metacat application, and not on the related metacatui image.
Previously, HZ was emitting an error in the log that it couldn't connect. Turns out the port was not exposed in docker. It still takes a while to connect, but the hz error is now gone.
The password file is now updated with the Metacat password admin utility.
Note that for now this only changes the context on the core metacat application, and not on the related metacatui image.
Previously, HZ was emitting an error in the log that it couldn't connect. Turns out the port was not exposed in docker. It still takes a while to connect, but the hz error is now gone.
… to externally-hosted postgres and solr instances, and a bind-mount for /var/metacat (to be revisited)
…ed to pass settings
…olr outside cluster
… all ENV vars except admin login
…nfig. Switching to a different branch to add properties overlays to metacat, then coming back to this branch to eliminate this duplication
… (old) moved repo
…ading new dataset)
…acat as RO, instead of making a copy to a RW persistent volume
…ue pairs from .Values.metacat to site props
…r runnign metacat. Added debug flag to values.yaml for the latter.
artntek
force-pushed
the
feature-1218-docker-image
branch
from
June 14, 2023 14:56
87049d8
to
67f90b1
Compare
… Necessitates alsu using python3 and installing 'unzip', plus a change to liveness/readiness probes so they don't return 404s now
mbjones
approved these changes
Jun 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been following along as this goes, and looks good to me, although I haven't yet run the code. Since the PR is all contained outside of regular metacat source, I will just approve the merge and then you can refactor later if/when we find stuff that needs to change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Issue #1623
Built on top of the work for #1218 (build a docker image for metacat) - the goal is to be able to use helm to install or upgrade metacat on a k8s cluster.